increase UnitTimeoutInactive inactivityTimeout #10692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/unittimeout_fail
branch
from
fe666d2 to
fad2c58
Compare
fails for me locally with --enable-debug 'CFLAGS=-O0 -ggdb' 'CXXFLAGS=-O0 -ggdb' Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I8cd0cb1d187bf3adab1f81345c1cd83b5180eee4
caolanm
force-pushed
the
private/caolan/unittimeout_fail
branch
from
fad2c58 to
4bee4fe
Compare
|
This is fairly edge case I guess, but it looks harmless to me to increase this. |
vmiklos
approved these changes
Jan 30, 2025
| @@ -37,7 +37,7 @@ class UnitTimeoutInactivity : public UnitTimeoutBase0 | |||
| void configure(Poco::Util::LayeredConfiguration& /* config */) override | |||
| { | |||
| // net::Defaults.inactivityTimeout = std::chrono::seconds(3600); | |||
| net::Defaults.inactivityTimeout = std::chrono::milliseconds(100); | |||
| net::Defaults.inactivityTimeout = std::chrono::milliseconds(150); | |||
There was a problem hiding this comment.
Aha, the default is 3600 seconds and we decrease this drastically to have a faster test, but then with 100ms we turn a stream socket into an inactive one so fast that it happens when no timeout should happen in a debug build, and increasing that decreased value makes the test more stable, while still not having to wait for 1h for the inactivity to happen. Makes sense after reading this about 3 times. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails for me locally with --enable-debug 'CFLAGS=-O0 -ggdb' 'CXXFLAGS=-O0 -ggdb'
Change-Id: I8cd0cb1d187bf3adab1f81345c1cd83b5180eee4
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay